+++ This bug was initially created as a clone of Bug #1737093 +++ Filling as a good first bug to learn workflows. if (mKeys.size() < 1) { should use .empty() instead https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/toolkit/mozapps/update/common/readstrings.cpp#340 As the change is trivial, it is just to learn how to contribute to Firefox. Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html Tutorial to contribute: https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Bug 1737096 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Filling as a good first bug to learn workflows.
if (mKeys.size() < 1) {
should use .empty() instead
https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/toolkit/mozapps/update/common/readstrings.cpp#340
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.